Markus Elfring
0f6cb93a09
Bug #165 : Deletion of unnecessary null pointer checks
The function "free" performs input parameter validation.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/free.html
It is therefore not needed to check a passed pointer before this function call.
A corresponding update suggestion was generated by the software "Coccinelle"
from the following semantic patch approach.
http://coccinelle.lip6.fr/
@Remove_unnecessary_pointer_checks1@
expression x;
@@
-if (x != \(0 \| NULL\))
free(x);
@Remove_unnecessary_pointer_checks2@
expression x;
@@
-if (x != \(0 \| NULL\)) {
free(x);
x = \(0 \| NULL\);
-}
@Remove_unnecessary_pointer_checks3@
expression a, b;
@@
-if (a != \(0 \| NULL\) && b != \(0 \| NULL\))
+if (a)
free(b);
@Remove_unnecessary_pointer_checks4@
expression a, b;
@@
-if (a != \(0 \| NULL\) && b != \(0 \| NULL\)) {
+if (a) {
free(b);
b = \(0 \| NULL\);
}
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
il y a 10 ans
Bert Münnich
056624548a
Beautified thumbnail marks and selection border
il y a 10 ans
Bert Münnich
fe3a1e326f
Further simplified thumbnail marks
il y a 10 ans
Bert Münnich
d0ba2c585d
Simplified thumbnail selection and marks
il y a 10 ans
Bert Münnich
e49d38d6f9
Fixed wrong thumbnail-to-file mappings caused by file deletions
il y a 10 ans
Bert Münnich
e267dc7793
Pass marked files to external key handler in thumbnail mode; fixes issue #135
il y a 10 ans
Bert Münnich
5b01c15176
Unified file index variable for image & thumbnail mode
il y a 10 ans
Bert Münnich
61f61cae5f
Generalized thumbnail loading, allows easier reloading of thumbnails later on
il y a 10 ans
Bert Münnich
bb6721549b
Overhauled window drawing, yet again; fixes issue #155
- Buffer for window content is bigger than the window, minimizes artifacts
when window is resized
- Back to using XSetWindowBackgroundPixmap() instead of XCopyArea(),
no need to handle exposure events; X server can show gray background directly
after resize event before sxiv redraws the window contents
il y a 10 ans
Bert Münnich
5cfae63620
Create thumbnail cache dir automatically
il y a 10 ans
Bert Münnich
cd02f2dd86
Small fix for thumbnail cropping
il y a 10 ans
Bert Münnich
d26f39914e
Use thumbnails in EXIF tags; requirement for libexif is back
il y a 10 ans
Bert Münnich
e685859a30
Use a checkerboard background for alpha layer; fixes issue #138
il y a 11 ans
Bert Münnich
304fd382db
Adhere to XDG Base Directory Specification; fixes issue #124
il y a 11 ans
Bert Münnich
99dfd14919
Fixed Imlib file handle type, issue #117
il y a 11 ans
Bert Münnich
38bc23405d
Highlight edges of marked images in thumbnail mode
il y a 11 ans
Bert Münnich
26a624a543
Added options for anti-alias & alpha layer coloring to config.def.h
Also removed now obsolete -p command line option; fixes issue #98
il y a 11 ans
Bert Münnich
08ae25da22
Refactored function definitions to use dangling brace
il y a 12 ans
Bert Münnich
6d3bbc6d5e
Updated/corrected license header
il y a 12 ans
Bert Münnich
b6a6c260e1
Moved thumbnail cache to ~/.sxiv/cache/
il y a 12 ans
Bert Münnich
5b6467913c
Made remote changes adhere to code style
il y a 12 ans
baskerville
c330b55de4
handle count prefix in thumbnail movements
il y a 12 ans
Bert Münnich
72071d5e9d
Fixed mem-leak in tns_init/tns_free
il y a 12 ans
Bert Münnich
edd016945a
Fixed it_scroll_move(DIR_DOWN) in thumb mode for last line
il y a 13 ans
Bert Münnich
3238ef6bf6
Fixed issue #41 , added WIN_FS_COLOR to config.h
il y a 13 ans
Bert Münnich
d407dd65d5
Already in the year 2012
il y a 13 ans
Bert Münnich
691c6d7e7e
Added own exif tag handling in files exif.[ch]
il y a 13 ans
Bert Münnich
b410c022a8
Fix recreation of thumbnail cache file after manual reload
il y a 13 ans
Bert Münnich
b8458271fb
Added text bar on bottom of window
il y a 13 ans
Bert Münnich
ef0ed32264
Removed exif support; made gif support non-optional
il y a 13 ans
Bert Münnich
ac4eb53029
Fixed issue #28 (again)
il y a 13 ans
Bert Münnich
5034792948
Thumbnails only get scaled down, fixed issue #27
il y a 13 ans
Bert Münnich
1cdbeb972a
Added screen-wise scrolling for thumbnail mode
il y a 13 ans
Bert Münnich
36177fb180
Updated contact information
il y a 13 ans
Bert Münnich
4383a651c7
Strictly adhere to ANSI-C standard
il y a 13 ans
Bert Münnich
a09b20c5e6
Use void for empty argument lists
il y a 13 ans
Bert Münnich
8dcf682de9
Made all conditionals more precise
il y a 13 ans
Bert Münnich
22d4e991d5
Transformed function macros in util.h to inline functions
il y a 13 ans
Bert Münnich
d721d8453e
Added STREQ macro
il y a 13 ans
Bert Münnich
515e410451
Use win_t member in img_t & tns_t instead of parameters
il y a 13 ans
Bert
dad06c7561
Much nicer handling of compile-time features
- *_SUPPORT enabled in config.h
- XLIBS helper app prints lib flags needed for current settings
il y a 13 ans
Bert
b2a2a62b7b
Added own bool type
il y a 13 ans
Bert
6e575b0f72
Strict conformance to IEEE Std 1003.1-2001
il y a 13 ans
Bert
03b8e85a4f
Fixed exif-only typo in tns_load()
il y a 13 ans
Bert
fdbc5cf76b
Added EXIF_SUPPORT macro for optional dependency on libexif
il y a 13 ans
Bert
bfab4dc328
Added EXIF auto-orientation
il y a 13 ans
Bert
26eae8be96
Made i(t)_toggle_alpha command work in thumbnail mode too
il y a 13 ans
Bert
d585b86354
Reformated license header
il y a 13 ans
Bert
de6b58a315
Unified feature test macro requirements
il y a 13 ans
Bert
1d7849efc1
Added force parameter to tns_load() to disregard cache
il y a 13 ans